Fix pharo-vcs#961

- configure remotes with the same protocol than the clone
- remove useless retry

Iceberg-Plugin-GitHub.package/IceHttpsProtocol.extension/class/githubRequestUrlKey.st

@@ -0,0 +1,4 @@
+*Iceberg-Plugin-GitHub
+githubRequestUrlKey
+
+	^ #'clone_url'

Iceberg-Plugin-GitHub.package/IceHttpsProtocol.extension/properties.json

@@ -0,0 +1,3 @@
+{
+	"name" : "IceHttpsProtocol"
+}

Iceberg-Plugin-GitHub.package/IceSSHProtocol.extension/class/githubRequestUrlKey.st

@@ -0,0 +1,4 @@
+*Iceberg-Plugin-GitHub
+githubRequestUrlKey
+
+	^ #'ssh_url'

Iceberg-Plugin-GitHub.package/IceSSHProtocol.extension/properties.json

@@ -0,0 +1,3 @@
+{
+	"name" : "IceSSHProtocol"
+}

Iceberg-Plugin-GitHub.package/IceTipGitHubRepositoryPanel.class/instance/getGitHubRepository.st

@@ -1,10 +1,7 @@
 querying-github
 getGitHubRepository
-	"It will retry 3 times"
-	1 to: 3 do: [ :attempt | 
-		[ [ ^ IceGitHubAPI new
-				beAnonymous;
-				getRepository: self userName project: self projectName ]
-			on: IceAuthenticationError do: [ "I will retry." ] ]
-			on: LGitNoCredentialsProvided do: [ ^ nil ] ].
-	^ nil
+	[ ^ IceGitHubAPI new
+		beAnonymous;
+		getRepository: self userName project: self projectName ]
+		on: LGitNoCredentialsProvided
+		do: [ ^ nil ]

Iceberg-Plugin-GitHub.package/IceTipGitHubRepositoryPanel.class/instance/newRepository.st

@@ -11,7 +11,7 @@ newRepository
 			(githubRepository at: #fork)
 				ifTrue: [ | parent remote |
 					parent := githubRepository at: #parent.
-					remote := IceGitRemote name: ((parent at: #owner) at: #login) url: (parent at: #'ssh_url').
+					remote := IceGitRemote name: ((parent at: #owner) at: #login) url: (parent at: self selectedProtocol githubRequestUrlKey).
 					newRepository addRemote: remote.
 					remote fetch. ] ].
 	^ newRepository

Iceberg-Plugin-GitHub.package/IceUrlProtocol.extension/class/githubRequestUrlKey.st

@@ -0,0 +1,4 @@
+*Iceberg-Plugin-GitHub
+githubRequestUrlKey
+	"Return the key used in github REST responses to get the URL with the correct protocol"
+	self subclassResponsibility

Iceberg-Plugin-GitHub.package/IceUrlProtocol.extension/properties.json

@@ -0,0 +1,3 @@
+{
+	"name" : "IceUrlProtocol"
+}