force "standard" (rubocop ruleset) to 1.0 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
due to some versioning shenanigans, we need to explicitly mark standard as being >= 1 -- message from bundle output below: --- Versions of Standard prior to 0.0.37 depended on `>= 0.63' of RuboCop, which means that Bundler continues to resolve to those (now ancient) versions whenever `gem "standard"' is added to a Gemfile that has already locked to a newer version of RuboCop than standard currently depends on. "How do I fix this?", you might be asking. How to fix this --------------- If you add a version specifier pinning `standard' to a version newer than 0.0.36.1, Bundler will resolve appropriate versions of `standard', `rubocop', and any other rubocop-dependent gems you may have installed.
per standard rubocop rules, the attribute is deprecated, and unused see: rubygems/guides#90
generally, only changes were assertion methods.
guilleiguaran
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to some versioning shenanigans, we need to explicitly mark
standardas being>= 1message from bundle output below:
standardrb/standard#340 (comment)