Scrutiniser recommendations (PHPOffice#1004)

guillaume-ro-fr · Jun 12, 2019 · 3b37c8f · 3b37c8f
1 parent 9bbb8dc
commit 3b37c8f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/samples/Autofilter/10_Autofilter_selection_1.php b/samples/Autofilter/10_Autofilter_selection_1.php
@@ -127,7 +127,7 @@
 // Filter the Date column on a filter value of the first day of every period of the current year
 // We us a dateGroup ruletype for this, although it is still a standard filter
 foreach ($periods as $period) {
-    $endDate = date('t', mktime(0, 0, 0, $period, 1, $currentYear));
+    $endDate = date('t', mktime(0, 0, 0, $period, 1, (int) $currentYear));
 
     $autoFilter->getColumn('D')
         ->setFilterType(Column::AUTOFILTER_FILTERTYPE_FILTER)

diff --git a/samples/Autofilter/10_Autofilter_selection_2.php b/samples/Autofilter/10_Autofilter_selection_2.php
@@ -67,7 +67,7 @@
                     $income = null;
                 } elseif ($incomeOrExpenditure == 1) {
                     $expenditure = rand(-500, -1000) * (1 + (rand(-1, 1) / 4));
-                    $income = rand(500, 1000) * (1 + rand(-0.25, +0.25));
+                    $income = rand(500, 1000) * (1 + (rand(-1, 1) / 4));
                 } else {
                     $expenditure = null;
                     $income = rand(500, 1000) * (1 + (rand(-1, 1) / 4));

diff --git a/samples/Autofilter/10_Autofilter_selection_display.php b/samples/Autofilter/10_Autofilter_selection_display.php
@@ -127,7 +127,7 @@
 // Filter the Date column on a filter value of the first day of every period of the current year
 // We us a dateGroup ruletype for this, although it is still a standard filter
 foreach ($periods as $period) {
-    $endDate = date('t', mktime(0, 0, 0, $period, 1, $currentYear));
+    $endDate = date('t', mktime(0, 0, 0, $period, 1, (int) $currentYear));
 
     $autoFilter->getColumn('D')
         ->setFilterType(Column::AUTOFILTER_FILTERTYPE_FILTER)