Added support for development SMTP servers like MailHog #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ill check this out later this week or in the beginning of next. Im at Node interactive conf currently |
|
I got to review it briefly but i like it. Im gonna do a more in-depth look at the code but regardless i will probably accept within the next couple days |
GreenPioneer
added a commit
that referenced
this pull request
Dec 5, 2016
Merged in pr #21 added devmode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A property describing a port for a local SMTP server (see MailHog) was added. If the property is omitted, sendmail behaves like it used to.
Motivation and Context
This feature makes it possible to test an application offline and for multiple email addresses without needing to create hundreds of mail accounts.
Types of changes