Prevent adding empty paragraph if cell contains altChunk #233
Conversation
|
Hi, thanks for contributing. Can you think of a test case for this that I can include in the project's test suite? Just a template with (a screenshot of) the before and after behaviour is fine, i'll make the snapshot test. |
|
Here is a test case. I created a new Word document, and added a table with the following content:
As you can see, I am using the following template to insert HTML: Using the current version of
Using the proposed code from this PR, below is the Word document that gets created. As you can see, no extra whitespace gets added.
|
|
Thanks, this makes sense! Sorry for the late reply. Merged manually in 653059a. |
I used docx-templates to generate a Word document with embedded HTML (altchunks) within cells of a table. In the generated document, I found that each of these cells ended up with extra whitespace beneath the HTML content.
I tracked it down to the code that adds a
<w:p/>if it finds that the table cell does not already contain a<w:p/>. This PR builds on that, by also checking to make sure the table cell does also not already contain a<w:altChunk>.After generating the same Word document again, using this PR, the embedded HTML no longer contains extra whitespace beneath the HTML content.