Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-evaluate need for Buffer polyfill #345

Closed
jjhbw opened this issue Jan 12, 2024 · 0 comments
Closed

Re-evaluate need for Buffer polyfill #345

jjhbw opened this issue Jan 12, 2024 · 0 comments
Assignees
@jjhbw

Comments

@jjhbw
Copy link
Collaborator

jjhbw commented Jan 12, 2024 •
edited
Loading

Typing every use of Buffer as ArrayBuffer should work fine.

Polyfills for Stream (for Sax) etc. are probably still required...
@jjhbw jjhbw self-assigned this Jan 12, 2024
jjhbw added a commit that referenced this issue Jan 12, 2024
@jjhbw
Issue #345: Make types for template more liberal: what works with Buf…
6e28a68 
…fer should work with ArrayBuffer, with the benefit that browsers don't need a polyfill.
@jjhbw jjhbw changed the title Re-evaluate need for browser polyfill (only used to polyfill Buffer) Re-evaluate need for Buffer polyfill Jan 12, 2024
jjhbw added a commit that referenced this issue Jan 12, 2024
@jjhbw
Issue #345: Make types for template more liberal: what works with Buf…
fad889f 
…fer should work with ArrayBuffer, with the benefit that browsers don't need a polyfill.
jjhbw added a commit that referenced this issue Jan 12, 2024
@jjhbw
Issue #345: Make types for template more liberal: what works with Buf…
bc53f03 
…fer should work with ArrayBuffer, with the benefit that browsers don't need a polyfill.
jjhbw added a commit that referenced this issue Jan 12, 2024
@jjhbw
Issue #345: Make types for template more liberal: what works with Buf…
4c1c007 
…fer should work with ArrayBuffer, with the benefit that browsers don't need a polyfill.
jjhbw added a commit that referenced this issue Jan 12, 2024
@jjhbw
Issue #345: Make types for template more liberal: what works with Buf…
ac067bd 
…fer should work with ArrayBuffer, with the benefit that browsers don't need a polyfill.
jjhbw added a commit that referenced this issue Jan 12, 2024
@jjhbw
Issue #345: Remove unnecessary polyfill.
99930b5
@jjhbw jjhbw closed this as completed Jan 12, 2024
jjhbw added a commit that referenced this issue Sep 25, 2024
@jjhbw
Restore Buffer polyfill to support e1032d9
277cb58 
Revert "Issue #345: Remove unnecessary polyfill."

This reverts commit 99930b5.
brijeshbv pushed a commit to BrandonDR/docx-templates that referenced this issue Nov 13, 2024
@jjhbw @brijeshbv
Restore Buffer polyfill to support e1032d9
4c7da85 
Revert "Issue guigrpa#345: Remove unnecessary polyfill."

This reverts commit 99930b5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjhbw jjhbw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jjhbw