Update govuk_elements to version 2.2.1 #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbarnett
approved these changes
Dec 2, 2016
|
@benbarnett @AndrewVos Give this a quick review once again, now that various test issues have been fixed |
benbarnett
reviewed
Dec 5, 2016
| $(function() { | ||
| 'use strict'; | ||
|
|
||
| jQuery.fx.off = true; |
benbarnett
reviewed
Dec 5, 2016
| @@ -23,5 +23,9 @@ class Application < Rails::Application | |||
| config.middleware.use BounceBrowserconfig | |||
|
|
|||
| config.mount_javascript_test_routes = false | |||
|
|
|||
| config.action_view.field_error_proc = proc { |html_tag, _| | |||
There was a problem hiding this comment.
I think this might be worth breaking into it's own commit to help explain what it does and why the change was made?
There was a problem hiding this comment.
Can we add a bit more of a 'why this was changed' thing to that commit msg?
benbarnett
reviewed
Dec 5, 2016
| @@ -20,5 +20,17 @@ class BookingStepTwo < SitePrism::Page | |||
|
|
|||
| element :submit, '.t-submit' | |||
| element :back, '.t-back' | |||
|
|
|||
| def check_hidden_checkbox(element, check) | |||
There was a problem hiding this comment.
As these radio buttons & checkboxes will be used everywhere now (e.g. the 'appointment summary page'), can these methods live somewhere more global?
Guntrisoft
force-pushed
the
update_govuk_elements
branch
2 times, most recently
from
0ac85d2 to
518d980
Compare
- made some minor adjustments to form to look good with new radio/checkbox styles Full list of changes: Remove the images path override from the helpers partial alphagov/govuk_elements#292 Bump govuk frontend toolkit to 4.16.1 alphagov/govuk_elements#288 Form validation patterns for conditionally revealing content alphagov/govuk_elements#286 Centre text on full-width buttons alphagov/govuk_elements#289 Lint JS code using StandardJS alphagov/govuk_elements#290 Update govuk_frontend_toolkit to 5.0.0 and govuk_template to 0.19.0 alphagov/govuk_elements#333 Add a select box example alphagov/govuk_elements#303 Add bullet points describing use of disabled buttons alphagov/govuk_elements#304 Add reasoning for native over custom file inputs Clear floats on details elements alphagov/govuk_elements#328 Add a .bold utility class alphagov/govuk_elements#321 Remove external link styles alphagov/govuk_elements#274 Remove rounded corners on form inputs elements and textareas in iOS alphagov/govuk_elements#342 Fix focus outline on form fields in Chrome / Safari alphagov/govuk_elements#346 Updates the contribution guidelines alphagov/govuk_elements#339 Recommend .visually-hidden over .visuallyhidden alphagov/govuk_elements#341 Add snippets for data visualisation examples alphagov/govuk_elements#350 alphagov/govuk_elements#351 Fix the grey left hand border example for Radios and checkboxes alphagov/govuk_elements#349 Fix the spacing underneath the "inline" block label example alphagov/govuk_elements#348 Custom radios / checkboxes alphagov/govuk_elements#296 Fix contrast issues with phase banners. Use $govuk-blue for the phase tag and update the examples alphagov/govuk_elements#364
- input is no longer clickable through Capybara with new style
radio/checkboxes as they have opacity: 0
- these methods use trigger('click') to hit the labels
associated with the inputs
- corrected other SitePrism objects to inherit from 'Page'
object to be consistent with others
- the field_with_errors div was causing an issue with the javascript for the new GOVUK style radio/checkboxes and was therefore not highlighting element which had an error in a form
Guntrisoft
force-pushed
the
update_govuk_elements
branch
from
518d980 to
3171fce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forms with radio buttons before
Forms with radio buttons after
Blog post explaining the change of style for radio/checkboxes
https://designnotes.blog.gov.uk/2016/11/30/weve-updated-the-radios-and-checkboxes-on-gov-uk/
new radio/checkbox styles
conflicts with new radio/checkbox JS modules
Full list of changes:
Remove the images path override from the helpers partial
alphagov/govuk_elements#292
Bump govuk frontend toolkit to 4.16.1
alphagov/govuk_elements#288
Form validation patterns for conditionally revealing content
alphagov/govuk_elements#286
Centre text on full-width buttons
alphagov/govuk_elements#289
Lint JS code using StandardJS
alphagov/govuk_elements#290
Update govuk_frontend_toolkit to 5.0.0 and govuk_template to 0.19.0
alphagov/govuk_elements#333
Add a select box example
alphagov/govuk_elements#303
Add bullet points describing use of disabled buttons
alphagov/govuk_elements#304
Add reasoning for native over custom file inputs
Clear floats on details elements
alphagov/govuk_elements#328
Add a .bold utility class
alphagov/govuk_elements#321
Remove external link styles
alphagov/govuk_elements#274
Remove rounded corners on form inputs elements and textareas in iOS
alphagov/govuk_elements#342
Fix focus outline on form fields in Chrome / Safari
alphagov/govuk_elements#346
Updates the contribution guidelines
alphagov/govuk_elements#339
Recommend .visually-hidden over .visuallyhidden
alphagov/govuk_elements#341
Add snippets for data visualisation examples
alphagov/govuk_elements#350
alphagov/govuk_elements#351
Fix the grey left hand border example for Radios and checkboxes
alphagov/govuk_elements#349
Fix the spacing underneath the "inline" block label example
alphagov/govuk_elements#348
Custom radios / checkboxes
alphagov/govuk_elements#296
Fix contrast issues with phase banners. Use $govuk-blue for the phase tag and update the examples
alphagov/govuk_elements#364