Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2961. v2 - WindowsDriver isn't render well on conhost terminal size. #2962

Closed

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Nov 8, 2023

Fixes #2961 - Two profile setting are needed for WindowsDriver, one for Windows Terminal (WT) and other for conhost (CH).

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working
VsDebugConsole_kaXPUKpzFW.mp4

@BDisp BDisp requested a review from tig as a code owner November 8, 2023 14:43
@tig
Copy link
Collaborator

tig commented Nov 15, 2023

@BDisp , if it's okay with you, I'd like to address this in #2610.

@BDisp
Copy link
Collaborator Author

BDisp commented Dec 4, 2023

Closing this because will be addressed on the #2610.

@BDisp BDisp closed this Dec 4, 2023
@BDisp BDisp deleted the v2_windowsdriver-conhost-fix_2961 branch December 4, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants