Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dim.Auto screws up Pos.AnchorEnd() #3473

Closed
2 tasks
tig opened this issue May 13, 2024 · 0 comments
Closed
2 tasks

Dim.Auto screws up Pos.AnchorEnd() #3473

tig opened this issue May 13, 2024 · 0 comments
Assignees
@tig
Labels
bug
Milestone
V2 Alpha

Comments

@tig
Copy link
Collaborator

tig commented May 13, 2024 •
edited
Loading

I missed a use case in my Dim.Auto testing. To repro, run the ComputedLayout scenario and notice the "Left" button is not aligned with the "Center" and "Right" buttons.

This only happens if Button.Height/Width are both Dim.Auto().

image

Todo:

  • Build a unit test for this
  • Figure out how to fix
@tig tig added the bug label May 13, 2024
@tig tig self-assigned this May 13, 2024
@tig tig mentioned this issue May 13, 2024
Merged
15 tasks
@tig tig moved this to 🆕 Not Triaged in Terminal.Gui V2 Alpha May 20, 2024
@tig tig moved this from 🆕 Not Triaged to 📋 Approved - Need Owner in Terminal.Gui V2 Alpha May 20, 2024
@tig tig moved this from 📋 Approved - Need Owner to 🏗 Approved - In progress in Terminal.Gui V2 Alpha May 20, 2024
tig added a commit that referenced this issue May 23, 2024
@tig
Merge pull request #3480 from tig/v2_3469-DimAuto-Absolute
1cfa2de 
Fixes #3469, #3473, #3482  - `Dim.Auto` fixes and `Pos`/`Dim` refactor to support TGD
@tig tig closed this as completed May 23, 2024
@github-project-automation github-project-automation bot moved this from 🏗 Approved - In progress to ✅ Done in Terminal.Gui V2 Alpha May 23, 2024
@tig tig added this to the V2 Alpha milestone May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tig tig

Labels
bug
Projects
No open projects
Terminal.Gui V2 Alpha
Status: ✅ Done
Terminal.Gui V2 Beta
Status: ✅ Done
Milestone
V2 Alpha
Development

No branches or pull requests
1 participant
@tig