Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WindowsDriver should return the mask keys to IsShift, IsAlt and IsCtrl return the right value. #3095

Closed
BDisp opened this issue Dec 28, 2023 · 0 comments

Comments

@BDisp
Copy link
Collaborator

BDisp commented Dec 28, 2023

If only the ShiftKey, AltKey or CtrlKey are used the Key.IsShift, Key.IsAlt or Key.IsCtrl returns false and should return true.

BDisp added a commit to BDisp/Terminal.Gui that referenced this issue Dec 28, 2023
…ft, IsAlt and IsCtrl return the right value.
BDisp added a commit to BDisp/Terminal.Gui that referenced this issue Dec 28, 2023
…ft, IsAlt and IsCtrl return the right value.
@tig tig closed this as completed Jan 4, 2024
tig added a commit that referenced this issue Jan 4, 2024
…broken") (#3078)

* Fixes #3054. VkeyPacketSimulator scenario is broken.

* Fix some key handle and unit tests.

* Remove unnecessary conditional.

* Improves key handling.

* Also allow map capslock to shift with accented characters.

* Change to MemberData.

* Remove unnecessary using.

* Fix merge errors.

* Fixes #3095. WindowsDriver should return the mask keys to IsShift, IsAlt and IsCtrl return the right value.

* Modifiers keys are valid to be handled on key down and key up.

* Map KeyCode.Enter to ConsoleKey.Enter and vice versa.

* Updated ScanCodeMapping table with readable constants

* Documented bugs

* Implemented mapping using MapVirtualKeyEx

* Implemented mapping using MapVirtualKeyEx

* Changed KeyCode special keys to match ConsoleKey values + max unicode codepoint

* Fixed bogus CollectionNavigator impl and tests

* Nuked DeleteChar. renamed InsertChar to Insert

* KeyCode.Enter = ConsoleKey.Enter, not \n

* Code cleanup

* Added diag for keyboard layout name

* Fixed AltGr support (hopefully)

* Simplified code

* Simplified KeyCode by removing ShiftKeys

* Fixed TextView

* Code cleanup

* Fixes cursesdriver (somewhat)

* Code cleanup

* netdriver wip

* Fixed netdriver under WSL

* Turned off debug spew

* Removed old code

---------

Co-authored-by: Tig Kindel <[email protected]>
Co-authored-by: Tig Kindel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants