Hub Types #758
Merged
Hub Types #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This comment was marked as resolved.
This comment was marked as resolved.
zsimjee
previously approved these changes
May 8, 2024
This comment was marked as resolved.
This comment was marked as resolved.
dtam
reviewed
Aug 12, 2024
dtam
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR swaps out the internal
ModuleManifestclass and it's children for the sharedManifestclass from hub-types.Before this PR can be opened completely, the new packages will need to be published. We will also need to validate and fix and manifests since the auto-generated
Manifestclass is a Pydantic Model and therefore more strict about structure.DEPENDS ON:
This PR contains breaking changes!
Note that the generated classes for the hub-types has a strict dependency on Pydantic 2.x (see the generator for more details: https://openapi-generator.tech/docs/generators/python). That means that guardrails will lose support for Pydantic 1.x once these changes are merged. Dropping support for 1.x was already planned, this just moved up the timeline. Since the old code and classes are compatibile with new manifest schema, these changes can wait until the next minor (pre-1.x-major) release.