Select logger config at runtime #971
Conversation
1. Adjusted some spacing and indentation 2. Reformatted with Black
Codecov Report
@@ Coverage Diff @@
## appimage #971 +/- ##
============================================
+ Coverage 19.10% 19.26% +0.15%
============================================
Files 337 337
Lines 11487 11502 +15
============================================
+ Hits 2195 2216 +21
+ Misses 9292 9286 -6
Continue to review full report at Codecov.
|
monkey/monkey_island.py
Outdated
| # TODO: Address https://github.com/guardicore/monkey/pull/963#discussion_r575022748 | ||
| # before merging appimage PR | ||
| (is_setup_only, server_config, logger_config) = parse_cli_args() |
There was a problem hiding this comment.
Would make sense to do it now?
| if os.path.exists(path): | ||
| with open(path, 'rt') as f: | ||
| with open(path, "rt") as f: |
There was a problem hiding this comment.
What's your take on " and '? I usually use ' for arguments and keys and " for strings (in log, exceptions, etc.). You think we should use only one?
There was a problem hiding this comment.
black picked double quotes in this scenario. There's no recommendation from PEP8 as to which to use in what cases.
…a todo, to move it to our fixture list
DeepCode failed to analyze this pull requestSomething went wrong despite trying multiple times, sorry about that. |
What does this PR do?
Allows the logger configuration to be specified at runtime.
PR Checklist
Testing Checklist