-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select server config at runtime #963
Merged
Merged
Commits on Feb 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 2f602a0 - Browse repository at this point
Copy the full SHA 2f602a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3289578 - Browse repository at this point
Copy the full SHA 3289578View commit details -
cc: rework EnvironmentConfig test
1. Rewrote in pytest 2. Removed reduntant tests 3. Added tests for add_user() and get_users()
Configuration menu - View commit details
-
Copy full SHA for 6bb76a2 - Browse repository at this point
Copy the full SHA 6bb76a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58ecbea - Browse repository at this point
Copy the full SHA 58ecbeaView commit details
Commits on Feb 12, 2021
-
cc: simplify constructor/factory interface for EnvironmentConfig
The `get_from_json()` and `get_from_dict()` static methods were really just used for testing. The `EnvironmentConfig` class needs to store its file path so it can wite to the file if needed. In practical usage, `EnvironmentConfig` objects are initialized from files, so a simpler interface is for its constructor to take a file path.
Configuration menu - View commit details
-
Copy full SHA for 6f918ce - Browse repository at this point
Copy the full SHA 6f918ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for f54d05b - Browse repository at this point
Copy the full SHA f54d05bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 07e48a0 - Browse repository at this point
Copy the full SHA 07e48a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d1d602 - Browse repository at this point
Copy the full SHA 3d1d602View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52f80e8 - Browse repository at this point
Copy the full SHA 52f80e8View commit details
Commits on Feb 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 737d1bb - Browse repository at this point
Copy the full SHA 737d1bbView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.