Fix UI bug in ATT&CK Report #949
Conversation
shreyamalviya
force-pushed
the
attack-report-bug-fix
branch
from
67d8a3b
to
21781d5
Compare
Codecov Report
@@ Coverage Diff @@
## develop #949 +/- ##
========================================
Coverage 19.07% 19.07%
========================================
Files 338 338
Lines 11482 11482
========================================
Hits 2190 2190
Misses 9292 9292 Continue to review full report at Codecov.
|
| @@ -159,7 +159,9 @@ class AttackReport extends React.Component { | |||
| } | |||
| // modify techniques' messages | |||
| for (const tech_id in techniques){ | |||
| techniques[tech_id]['message'] = <div dangerouslySetInnerHTML={{__html: marked(techniques[tech_id]['message'])}} />; | |||
| if (typeof techniques[tech_id]['message'] === 'string') { | |||
There was a problem hiding this comment.
Do we understand why the messages are objects instead of strings? What is the root cause of this issue? Are we just side-stepping it by checking the type?
There was a problem hiding this comment.
marked() modifies them in place. We need to change this behaviour(maybe there's a param for this? maybe we pass a copy of the string instead?)
There was a problem hiding this comment.
@VakarisZ Does marked() modify in place? All of the usage I can find implies that it returns a value, and javascript strings are immutable. https://marked.js.org/
There was a problem hiding this comment.
Oh, I think you mistyped and meant that modifyTechniqueData() modifies in-place. I think we're on the same page.
monkey/monkey_island/cc/ui/src/components/report-components/AttackReport.js
Outdated
Show resolved
Hide resolved
shreyamalviya
force-pushed
the
attack-report-bug-fix
branch
from
1c50b94
to
32b116c
Compare
Fixes #948
attack-report-bug-fix.mp4