Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zerologon Fingerprinter #868

Merged
merged 9 commits into from
Nov 5, 2020
Merged

Zerologon Fingerprinter #868

merged 9 commits into from
Nov 5, 2020

Conversation

shreyamalviya
Copy link
Contributor

@shreyamalviya shreyamalviya commented Oct 21, 2020 •
edited
Loading

@codecov
Copy link

codecov bot commented Oct 21, 2020 •
edited
Loading

Codecov Report

Merging #868 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #868   +/-   ##
========================================
  Coverage    60.52%   60.52%           
========================================
  Files          165      165           
  Lines         4948     4948           
========================================
  Hits          2995     2995           
  Misses        1953     1953

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53f3625...f44e080. Read the comment docs.

@shreyamalviya shreyamalviya marked this pull request as ready for review October 21, 2020 13:06
VakarisZ
VakarisZ reviewed Oct 21, 2020
View reviewed changes
monkey/infection_monkey/network/windowsserver_fingerprint.py Outdated
DC_HANDLE = '\\\\' + DC_NAME

if DC_NAME: # if it is a Windows DC
# Keep authenticating until successful. Expected average number of attempts needed: 256.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How long does it take?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~ 40 seconds

VakarisZ
VakarisZ approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@VakarisZ VakarisZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

VakarisZ
VakarisZ requested changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@VakarisZ VakarisZ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to update monkeyZoo

@shreyamalviya shreyamalviya merged commit b406495 into guardicore:develop Nov 5, 2020
@shreyamalviya shreyamalviya deleted the zerologon-fp branch November 11, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VakarisZ VakarisZ VakarisZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ZeroLogon Fingerprinter
2 participants
@shreyamalviya @VakarisZ