New Swimm Units #850
New Swimm Units #850
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #850 +/- ##
========================================
Coverage 60.52% 60.52%
========================================
Files 165 165
Lines 4948 4948
========================================
Hits 2995 2995
Misses 1953 1953 Continue to review full report at Codecov.
|
shreyamalviya
force-pushed
the
swimm-opensauced
branch
from
8f7de8a
to
07b9d17
Compare
shreyamalviya
force-pushed
the
swimm-opensauced
branch
from
07b9d17
to
e3b3ad8
Compare
| }, | ||
| "app_version": "0.1.90", | ||
| "file_version": "1.0.2" | ||
| } |
There was a problem hiding this comment.
Ah, Swimm committed these files. I reckon we should let these be just for consistency? Otherwise we'll have to edit the Swimm commit and add a newline every time.
| @@ -0,0 +1,31 @@ | |||
| { | |||
| "id": "VW4rf3AxRslfT7lwaug7", | |||
| "name": "Implement a new PBA — `ScheduleJobs`", | |||
There was a problem hiding this comment.
don't we already have this PBA? Maybe we should instead start with a more trivial task, like a PBA that adds a text tile to temp dir?
There was a problem hiding this comment.
Maybe we can add more playlists/units for trivial tasks; this one was used in the OpenSauced presentation so we should probably keep this separate.
There was a problem hiding this comment.
Actually, this doesn't require the swimmer to add the actual job scheduling commands. They're only required to fetch the commands from an already existing function, get_commands_to_schedule_jobs, which is mentioned in the unit's description. So it's not really hard.
Adds 3 new Swimm units for a new playlist (Adding a PBA in 5 Simple Steps, for Open Sauced):
ScheduleJobs