Run page ui improvements #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…un_page_ui_improvements # Conflicts: # monkey/monkey_island/cc/ui/src/components/pages/RunMonkeyPage/CommandDisplay.js # monkey/monkey_island/cc/ui/src/components/pages/RunMonkeyPage/LocalManualRunOptions.js # monkey/monkey_island/cc/ui/src/components/pages/RunMonkeyPage/ManualRunOptions.js # monkey/monkey_island/cc/ui/src/components/ui-components/inline-selection/BackButton.js # monkey/monkey_island/cc/ui/src/components/ui-components/inline-selection/InlineSelection.js # monkey/monkey_island/cc/ui/src/components/ui-components/inline-selection/NextSelectionButton.js # monkey/monkey_island/cc/ui/src/styles/Main.scss # monkey/monkey_island/cc/ui/src/styles/components/inline-selection/InlineSelection.scss
…ovements # Conflicts: # monkey/monkey_island/cc/ui/src/components/pages/RunMonkeyPage.js # monkey/monkey_island/cc/ui/src/styles/Main.scss
VakarisZ
force-pushed
the
run_page_ui_improvements
branch
from
8666765
to
dcf1b49
Compare
Codecov Report
@@ Coverage Diff @@
## develop #840 +/- ##
========================================
Coverage 60.52% 60.52%
========================================
Files 165 165
Lines 4948 4948
========================================
Hits 2995 2995
Misses 1953 1953 Continue to review full report at Codecov.
|
TheCoreMan
reviewed
Sep 21, 2020
monkey/monkey_island/cc/ui/src/components/pages/RunMonkeyPage/RunMonkeyPage.js
Show resolved
Hide resolved
itaymmguardicore
suggested changes
Sep 22, 2020
.travis.yml
Outdated
| @@ -89,7 +89,7 @@ script: | |||
| - cd monkey_island/cc/ui | |||
| - npm ci # See https://docs.npmjs.com/cli/ci.html | |||
| - eslint ./src --quiet # Test for errors | |||
| - JS_WARNINGS_AMOUNT_UPPER_LIMIT=4 | |||
| - JS_WARNINGS_AMOUNT_UPPER_LIMIT=8 | |||
There was a problem hiding this comment.
What are the new warnings? We can decide to not handle them now, but we need to be aware of them.
There was a problem hiding this comment.
https://travis-ci.com/github/guardicore/monkey/builds/185225218
New warnings are mainly caused by usage of ` instead of ' for strings.
This is a syntax which allows to display multiple classnames in a readable manner, so I don't want to remove it.
monkey/monkey_island/cc/ui/src/components/pages/RunMonkeyPage/RunMonkeyPage.js
Show resolved
Hide resolved
monkey/monkey_island/cc/ui/src/components/pages/RunMonkeyPage/RunOptions.js
Show resolved
Hide resolved
monkey/monkey_island/cc/ui/src/components/pages/RunMonkeyPage/RunOnIslandButton.js
Outdated
Show resolved
Hide resolved
monkey/monkey_island/cc/ui/src/components/ui-components/DropdownSelect.js
Outdated
Show resolved
Hide resolved
monkey/monkey_island/cc/ui/src/components/ui-components/DropdownSelect.js
Outdated
Show resolved
Hide resolved
monkey/monkey_island/cc/ui/src/components/pages/RunMonkeyPage/LocalManualRunOptions.js
Outdated
Show resolved
Hide resolved
itaymmguardicore
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #792
Improves run monkey UI with reusable react components, that allow further improvements and incorporation of other monkey run options.
Add any further explanations here.
PR Checklist
Testing Checklist