Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ATT&CK Report UI changes #820

Merged
merged 2 commits into from
Sep 2, 2020
Merged

ATT&CK Report UI changes #820

merged 2 commits into from
Sep 2, 2020

Conversation

shreyamalviya
Copy link
Contributor

@shreyamalviya shreyamalviya commented Sep 1, 2020 •
edited
Loading

This PR implements the following changes:

  • Color changes for disabled and not attempted techniques
  • Strikethrough disabled techniques' text

BEFORE:

and

AFTER:

and

@shreyamalviya
ATT&CK report UI changes
eba638e 
- color changes
- strikethrough disabled techiques' text in matrix
@codecov
Copy link

codecov bot commented Sep 1, 2020 •
edited
Loading

Codecov Report

Merging #820 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #820   +/-   ##
========================================
  Coverage    60.52%   60.52%           
========================================
  Files          165      165           
  Lines         4948     4948           
========================================
  Hits          2995     2995           
  Misses        1953     1953

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7107e96...e9dca67. Read the comment docs.

ShayNehmad
ShayNehmad approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@ShayNehmad ShayNehmad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please update the screenshots in the docs as well :)

@shreyamalviya shreyamalviya merged commit c0e6467 into guardicore:develop Sep 2, 2020
@shreyamalviya shreyamalviya deleted the MITRE-report-colors branch September 2, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShayNehmad ShayNehmad ShayNehmad approved these changes

@VakarisZ VakarisZ Awaiting requested review from VakarisZ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreyamalviya @ShayNehmad