UI router bugfix and loading screen #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n while UI is waiting for login status
Codecov Report
@@ Coverage Diff @@
## develop #779 +/- ##
========================================
Coverage 60.31% 60.31%
========================================
Files 161 161
Lines 4899 4899
========================================
Hits 2955 2955
Misses 1944 1944 Continue to review full report at Codecov.
|
VakarisZ
commented
Aug 25, 2020
| import monkeyDetective from '../../images/detective-monkey.svg'; | ||
| import ParticleBackground from "../ui-components/ParticleBackground"; |
There was a problem hiding this comment.
should change to single quotes
ShayNehmad
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed white screen on map/going to map bug, implemented loading screen while UI is waiting for login status
What is this?
Fixes #739 .
Implemented loading screen while UI is waiting for login status.
Proof that it works
This is how it looks like, when island is waiting for login status (on page refresh for example):
