Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py import order travis #727

Merged
merged 4 commits into from
Jul 16, 2020
Merged

Py import order travis #727

merged 4 commits into from
Jul 16, 2020

Conversation

ShayNehmad
Copy link
Contributor

What is this?

Fixes #725.

Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Have you successfully tested your changes locally?
  • Is the TravisCI build passing?

@ShayNehmad ShayNehmad self-assigned this Jul 15, 2020
fix issues in envs/ as well
@@ -20,7 +20,7 @@ install:
# Python
- pip freeze
- pip install -r monkey/monkey_island/requirements.txt # for unit tests
- pip install flake8 pytest dlint # for next stages
- pip install flake8 pytest dlint flake8-import-order # for next stages
- pip install coverage # for code coverage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to replace this with isort too

@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #727 into develop will decrease coverage by 0.03%.
The diff coverage is 97.82%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #727      +/-   ##
===========================================
- Coverage    59.89%   59.85%   -0.04%     
===========================================
  Files          147      147              
  Lines         4787     4783       -4     
===========================================
- Hits          2867     2863       -4     
  Misses        1920     1920              
Impacted Files Coverage Δ
monkey/infection_monkey/exploit/tools/helpers.py 36.36% <0.00%> (ø)
monkey/monkey_island/cc/testing/IslandTestCase.py 100.00% <ø> (ø)
monkey/infection_monkey/transport/http.py 21.15% <50.00%> (ø)
monkey/common/cloud/aws/aws_instance.py 47.72% <100.00%> (ø)
monkey/common/cloud/aws/aws_service_test.py 100.00% <100.00%> (ø)
monkey/common/network/network_range.py 81.90% <100.00%> (ø)
monkey/infection_monkey/control.py 20.37% <100.00%> (ø)
...ction_monkey/exploit/tools/payload_parsing_test.py 100.00% <100.00%> (ø)
...key/infection_monkey/exploit/tools/test_helpers.py 91.66% <100.00%> (ø)
...fection_monkey/model/victim_host_generator_test.py 100.00% <100.00%> (ø)
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c07cdfd...d3718a8. Read the comment docs.

@ShayNehmad ShayNehmad merged commit f92cf0d into develop Jul 16, 2020
@acepace acepace deleted the py-import-order-travis branch January 6, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants