-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Py import order travis #727
Conversation
fix issues in envs/ as well
@@ -20,7 +20,7 @@ install: | |||
# Python | |||
- pip freeze | |||
- pip install -r monkey/monkey_island/requirements.txt # for unit tests | |||
- pip install flake8 pytest dlint # for next stages | |||
- pip install flake8 pytest dlint flake8-import-order # for next stages | |||
- pip install coverage # for code coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to replace this with isort too
Codecov Report
@@ Coverage Diff @@
## develop #727 +/- ##
===========================================
- Coverage 59.89% 59.85% -0.04%
===========================================
Files 147 147
Lines 4787 4783 -4
===========================================
- Hits 2867 2863 -4
Misses 1920 1920
Continue to review full report at Codecov.
|
What is this?
Fixes #725.
Checklist