Add T1168 and T1053 attack techniques (job scheduling) #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyamalviya
force-pushed
the
T1168-T1053
branch
from
e92fdae
to
b0c3b50
Compare
Codecov Report
@@ Coverage Diff @@
## develop #694 +/- ##
========================================
Coverage 59.89% 59.89%
========================================
Files 147 147
Lines 4787 4787
========================================
Hits 2867 2867
Misses 1920 1920
Continue to review full report at Codecov.
|
VakarisZ
reviewed
Jul 1, 2020
monkey/infection_monkey/post_breach/job_scheduling/windows/job_scheduling.py
Outdated
Show resolved
Hide resolved
VakarisZ
reviewed
Jul 1, 2020
monkey/infection_monkey/post_breach/job_scheduling/windows/job_scheduling.py
Outdated
Show resolved
Hide resolved
VakarisZ
reviewed
Jul 1, 2020
Comment on lines
+1
to
+4
| from monkey_island.cc.services.attack.technique_reports import AttackTechnique | ||
| from monkey_island.cc.database import mongo | ||
| from common.utils.attack_utils import ScanStatus | ||
| from common.data.post_breach_consts import POST_BREACH_JOB_SCHEDULING |
There was a problem hiding this comment.
Ideally, all imports should follow the same structure:
future imports
python imports
third party imports
project imports
If not sure about why, look up PEP8.
You can automatically achieve this on pycharm with ctrl + alt + o.
There was a problem hiding this comment.
Maybe we should add https://pypi.org/project/flake8-import-order/
VakarisZ
reviewed
Jul 1, 2020
monkey/infection_monkey/post_breach/job_scheduling/linux/job_scheduling.py
Outdated
Show resolved
Hide resolved
VakarisZ
reviewed
Jul 1, 2020
monkey/infection_monkey/post_breach/job_scheduling/linux/job_scheduling.py
Outdated
Show resolved
Hide resolved
VakarisZ
requested changes
Jul 1, 2020
VakarisZ
reviewed
Jul 1, 2020
monkey/infection_monkey/post_breach/job_scheduling/job_scheduling.py
Outdated
Show resolved
Hide resolved
shreyamalviya
force-pushed
the
T1168-T1053
branch
2 times, most recently
from
f911495
to
5bef26b
Compare
ShayNehmad
suggested changes
Jul 12, 2020
monkey/infection_monkey/post_breach/job_scheduling/linux_job_scheduling.py
Outdated
Show resolved
Hide resolved
- windows commands readibility - f-strings - directory structure
shreyamalviya
force-pushed
the
T1168-T1053
branch
from
5bef26b
to
5bbef83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #683 and fixes #685
T1168 and T1053 both aim at scheduling jobs.