Bugfix/remove wmi requirement from non windows #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 11, 2020 14:35
Moved WMI imports to be gated behind win32 check. Set wmi package to be installed only on win32 platform. The mongo_utils and wmi_utils modules are only imported by the windows_info_collector which is only imported if we're on windows.
|
About In this commit: It's being moved from the windows info collector (where it was commented out) to a utils file. Was it ever actually used? If so, what for? |
ShayNehmad
approved these changes
May 11, 2020
|
I think we used it as part of a long ago PTH collection effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Simplifies requirements.txt for the Monkey by removing need to install wmi package on Linux envs
Linux keeps working
