Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/fix ui build problems #643

Merged
merged 8 commits into from
May 11, 2020
Merged

Hotfix/fix ui build problems #643

merged 8 commits into from
May 11, 2020

Conversation

ShayNehmad
Copy link
Contributor

@ShayNehmad ShayNehmad commented May 11, 2020 •
edited
Loading

What is this?

Fixes broken UI build.

Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Have you successfully tested your changes locally?
  • Is the TravisCI build passing?

Proof that it works

image

Changes

Commit messages.

@ShayNehmad ShayNehmad added Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. UI User Interface labels May 11, 2020
@ShayNehmad ShayNehmad self-assigned this May 11, 2020
@codecov
Copy link

codecov bot commented May 11, 2020 •
edited
Loading

Codecov Report

Merging #643 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #643   +/-   ##
========================================
  Coverage    57.58%   57.58%           
========================================
  Files          116      116           
  Lines         3890     3890           
========================================
  Hits          2240     2240           
  Misses        1650     1650

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f070517...6cf8130. Read the comment docs.

@acepace
Copy link
Contributor

acepace commented May 11, 2020

Builds on my machine, but the revert also built so 🤷‍♀️

@ShayNehmad ShayNehmad requested a review from VakarisZ May 11, 2020 13:00
VakarisZ
VakarisZ approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@VakarisZ VakarisZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@ShayNehmad ShayNehmad merged commit e73c1d0 into develop May 11, 2020
@ShayNehmad ShayNehmad deleted the hotfix/fix-ui-build-problems branch May 11, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VakarisZ VakarisZ VakarisZ approved these changes

Assignees

@ShayNehmad ShayNehmad

Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. UI User Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShayNehmad @acepace @VakarisZ