Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/1.8.0 fix deb python version #609

Merged
merged 15 commits into from
Apr 13, 2020

Conversation

ShayNehmad
Copy link
Contributor

@ShayNehmad ShayNehmad commented Apr 9, 2020

What is this?

Update out .deb package python version to 3.7.

This removes our (OOTB) support for Ubuntu 16 and lower.

Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Have you successfully tested your changes locally?
  • Is the TravisCI build passing?

@ShayNehmad ShayNehmad added this to the 1.8.0 milestone Apr 9, 2020
@ShayNehmad ShayNehmad self-assigned this Apr 9, 2020
@ShayNehmad ShayNehmad changed the base branch from develop to release/1.8.0 April 9, 2020 13:22
@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #609 into release/1.8.0 will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/1.8.0     #609   +/-   ##
==============================================
  Coverage          56.78%   56.78%           
==============================================
  Files                115      115           
  Lines               3871     3871           
==============================================
  Hits                2198     2198           
  Misses              1673     1673           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8c1407...592fd88. Read the comment docs.


echo "Installing Python dependencies using $(command -v pip)..."
# First, make sure that pip is updated
${PYTHON_FOLDER}/bin/python -m pip install --upgrade pip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you ran source above, why are you fully qualifying your python command?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

echo "Monkey Island installation ended."
echo "The server should be accessible soon via https://<server_ip>:5000/"
echo "To check the Island's status, run 'sudo service monkey-island status'"
echo ""

exit 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 11 to 12
dd bs=1024 count=2 </dev/urandom >~/.rnd
chmod 666 ~/.rnd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And if you don't have permissions to ~ or if the file exists?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9687b22

The user which runs ./create_cert will have access to their own ~ folder in enough of the cases that I'm willing to leave this in. No other workaround that doesn't involve carrying openssl with us or messing with worse things in the system that I could fine.

Copy link
Contributor

@itaymmguardicore itaymmguardicore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Pretty much no further comments to those Daniel posted.
Let's talk about it

I added more comments, so it must be fine 🔥 🐶 🔥
Added which python it to the debug prints to compensate
@ShayNehmad ShayNehmad merged commit 9d1e163 into release/1.8.0 Apr 13, 2020
@ShayNehmad ShayNehmad deleted the bugfix/1.8.0-fix-deb-python-version branch April 13, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants