-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/1.8.0 fix deb python version #609
Bugfix/1.8.0 fix deb python version #609
Conversation
Installed with pymongo in a maintained project
…d whl like netifaces
moved to postinst
Codecov Report
@@ Coverage Diff @@
## release/1.8.0 #609 +/- ##
==============================================
Coverage 56.78% 56.78%
==============================================
Files 115 115
Lines 3871 3871
==============================================
Hits 2198 2198
Misses 1673 1673 Continue to review full report at Codecov.
|
This is a known issue with openssl and once ubuntu 18 gets a new version we can delete this
|
||
echo "Installing Python dependencies using $(command -v pip)..." | ||
# First, make sure that pip is updated | ||
${PYTHON_FOLDER}/bin/python -m pip install --upgrade pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you ran source above, why are you fully qualifying your python command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo "Monkey Island installation ended." | ||
echo "The server should be accessible soon via https://<server_ip>:5000/" | ||
echo "To check the Island's status, run 'sudo service monkey-island status'" | ||
echo "" | ||
|
||
exit 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dd bs=1024 count=2 </dev/urandom >~/.rnd | ||
chmod 666 ~/.rnd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And if you don't have permissions to ~ or if the file exists?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user which runs ./create_cert will have access to their own ~ folder in enough of the cases that I'm willing to leave this in. No other workaround that doesn't involve carrying openssl with us or messing with worse things in the system that I could fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed. Pretty much no further comments to those Daniel posted.
Let's talk about it
I added more comments, so it must be fine 🔥 🐶 🔥
Added which python it to the debug prints to compensate
What is this?
Update out .deb package python version to 3.7.
This removes our (OOTB) support for Ubuntu 16 and lower.
Checklist