Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix pyinstaller spec file - datas paths #559

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Hotfix pyinstaller spec file - datas paths #559

merged 1 commit into from
Mar 2, 2020

Conversation

ShayNehmad
Copy link
Contributor

@ShayNehmad ShayNehmad commented Mar 1, 2020 •
edited
Loading

The tuple is from source file to dst folder. https://stackoverflow.com/a/59710336/4119906

What is this?

Hotfix for the #543 pr.

Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Have you successfully tested your changes locally?
  • Is the TravisCI build passing?

Proof that it works

image

@ShayNehmad ShayNehmad added Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Monkey labels Mar 1, 2020
@ShayNehmad ShayNehmad added this to the 1.8.0 milestone Mar 1, 2020
@ShayNehmad ShayNehmad self-assigned this Mar 1, 2020
@ShayNehmad ShayNehmad changed the title fix pyinstaller spec file - datas paths Hotfix pyinstaller spec file - datas paths Mar 1, 2020
@ShayNehmad ShayNehmad merged commit 48875b0 into develop Mar 2, 2020
@ShayNehmad ShayNehmad deleted the hotfix/pyinstaller-datas-build-path branch March 2, 2020 08:50
@ShayNehmad ShayNehmad mentioned this pull request Mar 2, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Feb 11, 2023
Open
@SarmadBytes SarmadBytes mentioned this pull request Nov 23, 2023
Open
@SarmadBytes SarmadBytes mentioned this pull request Mar 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielguardicore danielguardicore Awaiting requested review from danielguardicore

Assignees

@ShayNehmad ShayNehmad

Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island.
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
1 participant
@ShayNehmad