Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Infection Monkey requirements files #500

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Merge Infection Monkey requirements files #500

merged 1 commit into from
Nov 26, 2019

Conversation

danielguardicore
Copy link
Contributor

@danielguardicore danielguardicore commented Nov 26, 2019 •
edited
Loading

What is this?

Simplifies our development setup by using only a single requirements file for both Infection Monkey platforms.

Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Have you successfully tested your changes locally?
  • Is the TravisCI build passing?

@danielguardicore danielguardicore added Monkey Documentation Issues relating to the project's documentation like readme files, guides, etc. labels Nov 26, 2019
@danielguardicore danielguardicore self-assigned this Nov 26, 2019
VakarisZ
VakarisZ reviewed Nov 26, 2019
View reviewed changes
monkey/infection_monkey/requirements.txt
@@ -10,5 +10,6 @@ ecdsa
netifaces
ipaddress
wmi
pywin32 ; sys_platform == 'win32'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is our only different requirement?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell

VakarisZ
VakarisZ approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@VakarisZ VakarisZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If pip installation is tested than consider it approved

@danielguardicore danielguardicore merged commit a46bf00 into develop Nov 26, 2019
@danielguardicore danielguardicore deleted the bugfix/merge_requirements_files branch November 28, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VakarisZ VakarisZ VakarisZ approved these changes

@ShayNehmad ShayNehmad Awaiting requested review from ShayNehmad

Assignees

@danielguardicore danielguardicore

Labels
Documentation Issues relating to the project's documentation like readme files, guides, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielguardicore @VakarisZ