Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add more descriptive message upon submitting invalid credentials #3977

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

ilija-lazoroski
Copy link
Contributor

@ilija-lazoroski ilija-lazoroski commented Dec 22, 2023

Issue: #3942

What does this PR do?

Fixes #3942

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

image

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4fe4bed) 77.57% compared to head (86bebfe) 77.57%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3977   +/-   ##
========================================
  Coverage    77.57%   77.57%           
========================================
  Files          467      467           
  Lines        14759    14759           
========================================
  Hits         11450    11450           
  Misses        3309     3309           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mssalvatore mssalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but it might be worth rolling up identical messages. E.g. ("3 invalid NTLM hashes were found")

@ilija-lazoroski ilija-lazoroski force-pushed the 3942-fix-vague-invalid-credentials-message branch from e0a7f64 to 86bebfe Compare December 22, 2023 15:21
@ilija-lazoroski ilija-lazoroski merged commit 7bcf0af into develop Dec 22, 2023
3 checks passed
@ilija-lazoroski ilija-lazoroski deleted the 3942-fix-vague-invalid-credentials-message branch December 22, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vague "invalid credentials" message
4 participants