[DONE] Added assertion of mongo db version.

[ShayNehmad]

Also refactored a bit to make the main shorter.

Feature / Fixes

Changes/Fixes the following feature

Fixes #337

• Have you added an explanation of what your changes do and why you'd like to include them?

• Have you successfully tested your changes locally?

• Example screenshot/log transcript of the feature working

Version is good

sudo+ssh://[email protected]:22/usr/bin/python -u /home/shay/monkey/monkey/monkey_island.py 2019-06-05 19:24:37,119 - environment.py:46 - <module>() - INFO - Monkey's env is: StandardEnvironment 2019-06-05 19:24:38,104 - main.py:60 - wait_for_mongo_db_server() - INFO - Waiting for MongoDB server on mongodb://localhost:27017/monkeyisland 2019-06-05 19:24:39,608 - main.py:60 - wait_for_mongo_db_server() - INFO - Waiting for MongoDB server on mongodb://localhost:27017/monkeyisland 2019-06-05 19:24:41,113 - main.py:60 - wait_for_mongo_db_server() - INFO - Waiting for MongoDB server on mongodb://localhost:27017/monkeyisland 2019-06-05 19:24:42,618 - main.py:60 - wait_for_mongo_db_server() - INFO - Waiting for MongoDB server on mongodb://localhost:27017/monkeyisland 2019-06-05 19:24:43,629 - main.py:77 - assert_mongo_db_version() - INFO - Mongo DB version OK. Got (u'4', u'0', u'8')

Version is bad (I upped the required version to 6.0.0)

sudo+ssh://[email protected]:22/usr/bin/python -u /home/shay/monkey/monkey/monkey_island.py 2019-06-05 19:27:31,436 - environment.py:46 - <module>() - INFO - Monkey's env is: StandardEnvironment 2019-06-05 19:27:31,917 - main.py:74 - assert_mongo_db_version() - ERROR - Mongo DB version too old. ('6', '0', '0') is required, but got (u'4', u'0', u'8') Process finished with exit code 255

[danielguardicore]

Why 4? I thought we need 3.6

[ShayNehmad]

I'm not sure what's the absolute minimum, but why not use 4.0.0? The current stable is 4.0.10 ( https://docs.mongodb.com/manual/release-notes/4.0/ ) , and 4.0.0 is months old by now.

[danielguardicore]

Because Ubuntu 18.04 still provides only 3.6 and people may install that way.
https://launchpad.net/ubuntu/bionic/+source/mongodb

[ShayNehmad]

✔ That's a good reason