3165 credentials generator #3366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mssalvatore
added a commit
that referenced
this pull request
May 22, 2023
mssalvatore
force-pushed
the
3165-credentials-generator
branch
from
7101967
to
77530a1
Compare
cakekoa
reviewed
May 22, 2023
|
|
||
| powershell_credentials: List[Credentials] = [] | ||
|
|
||
| # Note that if no secrets are provided, generate_brute_force_credentials() will generate return |
There was a problem hiding this comment.
Suggested change
| # Note that if no secrets are provided, generate_brute_force_credentials() will generate return | |
| # Note that if no secrets are provided, generate_brute_force_credentials() will return |
| input_credentials = [Credentials(identity=i, secret=None) for i in INPUT_IDENTITIES] | ||
| generated_credentials = generate_powershell_credentials(input_credentials, False) | ||
|
|
||
| assert len(generated_credentials) == 4 |
There was a problem hiding this comment.
It might be cool to be able to assert that, say, the cached credentials are not part of the generated credentials
| from common.credentials import Credentials, LMHash, NTHash, Password, Secret, Username | ||
|
|
||
| TEST_DOMAIN = "TEST-DOMAIN" | ||
| LOCAL_USER = "localuser" |
There was a problem hiding this comment.
Should we have a test for if the local username is already in the propagation credentials? With/without the domain?
shreyamalviya
approved these changes
May 23, 2023
ilija-lazoroski
approved these changes
May 23, 2023
shreyamalviya
pushed a commit
that referenced
this pull request
May 23, 2023
shreyamalviya
pushed a commit
that referenced
this pull request
May 23, 2023
shreyamalviya
force-pushed
the
3165-credentials-generator
branch
from
77530a1
to
f681f95
Compare
mssalvatore
force-pushed
the
3165-credentials-generator
branch
from
f681f95
to
3ccf483
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Issue #3165
Adds a credentials generator for powershell plugin
PR Checklist
Testing Checklist