Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hadoop port filtering improvements #3238

Merged
merged 5 commits into from
Apr 21, 2023

Conversation

mssalvatore
Copy link
Collaborator

@mssalvatore mssalvatore commented Apr 21, 2023

What does this PR do?

Adds open property to PortScanDataDict
Reimplements some Hadoop methods using the open and closed properties from PortScanDataDict

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (adf4992) 73.10% compared to head (8cf1506) 73.11%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3238   +/-   ##
========================================
  Coverage    73.10%   73.11%           
========================================
  Files          467      467           
  Lines        13670    13675    +5     
========================================
+ Hits          9993     9998    +5     
  Misses        3677     3677           

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mssalvatore mssalvatore merged commit 1f51bc0 into develop Apr 21, 2023
@mssalvatore mssalvatore deleted the hadoop-port-filtering-improvements branch April 21, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants