Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Island: Change Token to a SecretStr #3211

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Apr 7, 2023

What does this PR do?

Fixes part of #3078 by changing Token to a SecretStr.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by running the agent from source, as well as running the BB logout test

  • If applicable, add screenshots or log transcripts of the feature working

@mssalvatore mssalvatore merged commit 1d01c41 into develop Apr 7, 2023
@mssalvatore mssalvatore deleted the 3078-make-token-secretstr branch April 7, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants