Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Island: Use OTP in local agent run #3194

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Island: Use OTP in local agent run #3194

merged 3 commits into from
Apr 4, 2023

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Apr 4, 2023

What does this PR do?

Fixes part of #3078.

Passes the OTP to the agent when doing a "Run From Island" scenario.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by running the island locally and verifying that the OTP is used by the agent

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

❗ No coverage uploaded for pull request base (3078-implement-AgentOTP-resource@d64b7cb). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 2a60278 differs from pull request most recent head 05cebe0. Consider uploading reports for the commit 05cebe0 to get more accurate results

Additional details and impacted files
@@                         Coverage Diff                         @@
##             3078-implement-AgentOTP-resource    #3194   +/-   ##
===================================================================
  Coverage                                    ?   72.88%           
===================================================================
  Files                                       ?      471           
  Lines                                       ?    13464           
  Branches                                    ?        0           
===================================================================
  Hits                                        ?     9813           
  Misses                                      ?     3651           
  Partials                                    ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mssalvatore mssalvatore changed the base branch from develop to 3078-implement-AgentOTP-resource April 4, 2023 17:42
@cakekoa cakekoa changed the base branch from 3078-implement-AgentOTP-resource to develop April 4, 2023 18:02
@cakekoa cakekoa merged commit 146b4c8 into develop Apr 4, 2023
@mssalvatore mssalvatore deleted the 3078-run-from-island branch April 7, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants