Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Island: Move construction of AuthenicationFacade #3190

Merged
merged 3 commits into from
Apr 4, 2023

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Apr 3, 2023

What does this PR do?

Fixes #put issue number here.

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.07 🎉

Comparison is base (6f9a2ea) 72.81% compared to head (3a13ba9) 72.89%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3190      +/-   ##
===========================================
+ Coverage    72.81%   72.89%   +0.07%     
===========================================
  Files          471      471              
  Lines        13451    13453       +2     
===========================================
+ Hits          9794     9806      +12     
+ Misses        3657     3647      -10     

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shreyamalviya shreyamalviya mentioned this pull request Apr 4, 2023
10 tasks
@mssalvatore mssalvatore force-pushed the 3078-move-auth-facade-construction branch from 42aadcb to 3a13ba9 Compare April 4, 2023 13:59
@mssalvatore mssalvatore marked this pull request as ready for review April 4, 2023 14:01
@mssalvatore mssalvatore merged commit 23779fe into develop Apr 4, 2023
@mssalvatore mssalvatore deleted the 3078-move-auth-facade-construction branch April 4, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants