Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3078 otp repository #3186

Merged
merged 6 commits into from
Apr 3, 2023
Merged

3078 otp repository #3186

merged 6 commits into from
Apr 3, 2023

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Mar 31, 2023

What does this PR do?

Fixes part of #3078 by adding classes to support storing/retrieving OTPs.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.08 🎉

Comparison is base (36fc429) 72.67% compared to head (9df9fe8) 72.75%.

❗ Current head 9df9fe8 differs from pull request most recent head e1e6410. Consider uploading reports for the commit e1e6410 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3186      +/-   ##
===========================================
+ Coverage    72.67%   72.75%   +0.08%     
===========================================
  Files          469      471       +2     
  Lines        13385    13425      +40     
===========================================
+ Hits          9728     9768      +40     
  Misses        3657     3657              

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

otp: str
"""One-time password (OTP)"""

expiration_time: datetime
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be using seconds from time.monotonic() for this? As written, changes to the system clock could cause the token to be valid for longer than desired.

monkey/monkey_island/cc/repositories/i_otp_repository.py Outdated Show resolved Hide resolved
monkey/monkey_island/cc/repositories/i_otp_repository.py Outdated Show resolved Hide resolved
@mssalvatore mssalvatore mentioned this pull request Apr 3, 2023
10 tasks
mssalvatore added a commit that referenced this pull request Apr 3, 2023
@mssalvatore mssalvatore merged commit 43a5815 into develop Apr 3, 2023
@mssalvatore mssalvatore deleted the 3078-otp-repository branch April 3, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants