-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3078 otp repository #3186
3078 otp repository #3186
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #3186 +/- ##
===========================================
+ Coverage 72.67% 72.75% +0.08%
===========================================
Files 469 471 +2
Lines 13385 13425 +40
===========================================
+ Hits 9728 9768 +40
Misses 3657 3657 see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
otp: str | ||
"""One-time password (OTP)""" | ||
|
||
expiration_time: datetime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be using seconds from time.monotonic()
for this? As written, changes to the system clock could cause the token to be valid for longer than desired.
9df9fe8
to
4984132
Compare
What does this PR do?
Fixes part of #3078 by adding classes to support storing/retrieving OTPs.
PR Checklist
Testing Checklist