Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2865 update node packages #3052

Merged
merged 20 commits into from
Mar 6, 2023
Merged

2865 update node packages #3052

merged 20 commits into from
Mar 6, 2023

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Mar 6, 2023

What does this PR do?

Fixes #2865.

Updates node packages to newer versions. The biggest change addressed here is updating react-router-dom 5.X -> 6.X. Other things to note:

  • babel-eslint changed to @babel/eslint-parser
  • @emotion/core changed to @emotion/react
  • react-json-tree no longer exports a JSONTree by default

A few packages can still be upgraded, but would take more effort:

  • bootstrap 4.X -> 5.X
  • mui-datatables 3.X -> 4.X
  • react-table -> @tanstack/react-table
  • react-tsparticles 1.X -> 2.X

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (f54a292) 67.26% compared to head (cc7bc48) 67.24%.

❗ Current head cc7bc48 differs from pull request most recent head 45382e0. Consider uploading reports for the commit 45382e0 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3052      +/-   ##
===========================================
- Coverage    67.26%   67.24%   -0.02%     
===========================================
  Files          439      439              
  Lines        12636    12632       -4     
===========================================
- Hits          8499     8495       -4     
  Misses        4137     4137              
Impacted Files Coverage Δ
monkey/monkey/monkey_island/cc/models/agent.py 100.00% <0.00%> (ø)
...island_event_handlers/handle_agent_registration.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mssalvatore
Copy link
Collaborator

Resolves #3027, #3026, #3025, #3024

Copy link
Contributor

@VakarisZ VakarisZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but not tested

Copy link
Collaborator

@mssalvatore mssalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that there's an infinite loop. When the security reports page is opened after and agent runs, the Island's API is bombarded with requests.

@mssalvatore mssalvatore merged commit b454c88 into develop Mar 6, 2023
@mssalvatore mssalvatore deleted the 2865-update-node-packages branch March 6, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update npm packages
4 participants