Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate events in preview pane on map page #2468

Merged

Conversation

shreyamalviya
Copy link
Contributor

What does this PR do?

Fixes a part of #2430

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

With dummy data:
image

@VakarisZ VakarisZ force-pushed the 2430-aggregate-events-in-preview-pane branch from 5869dc4 to 18e5b77 Compare October 21, 2022 14:32
Each map node only had one agentID, while in reality multiple agents could've run. By saving all agents into mapNode we can figure out which agent belongs to which machine
@VakarisZ VakarisZ marked this pull request as ready for review October 24, 2022 10:22
@VakarisZ
Copy link
Contributor

Updated UI:
image

@mssalvatore mssalvatore merged commit d7c5f10 into 2430-exploit-timeline Oct 24, 2022
@mssalvatore mssalvatore deleted the 2430-aggregate-events-in-preview-pane branch October 24, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants