Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2269 remove pthreportservice #2418

Merged
merged 5 commits into from
Oct 13, 2022
Merged

2269 remove pthreportservice #2418

merged 5 commits into from
Oct 13, 2022

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Oct 11, 2022

What does this PR do?

Fixes part of #2269.

Removes the PTHReportService, which was reading from an unpopulated database. Removes the sections from the UI that correspond to the portions of the report that relied on the service. These portions were already empty.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?

  • Have you successfully tested your changes locally? Elaborate:

    Tested by running in the zoo environment

  • If applicable, add screenshots or log transcripts of the feature working
    A map of the run:
    Screen Shot 2022-10-11 at 12 43 26 PM

    Observe that the domain recommendations are not displayed:
    Screen Shot 2022-10-11 at 12 44 04 PM

    Observe that the "Powerful Users" table is no longer displayed:
    Screen Shot 2022-10-11 at 12 44 36 PM

Copy link
Contributor

@VakarisZ VakarisZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I don't think this ever worked

@cakekoa cakekoa changed the base branch from 2269-update-reports-with-exploitation-events to develop October 13, 2022 11:58
@cakekoa cakekoa merged commit f918260 into develop Oct 13, 2022
@mssalvatore mssalvatore deleted the 2269-remove-pthreportservice branch December 1, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants