-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2269 update reports with exploitation events #2414
2269 update reports with exploitation events #2414
Conversation
monkey/monkey_island/cc/ui/src/components/report-components/security/issues/SshIssue.js
Outdated
Show resolved
Hide resolved
monkey/monkey_island/cc/ui/src/components/report-components/security/issues/SshIssue.js
Outdated
Show resolved
Hide resolved
Codecov ReportBase: 60.90% // Head: 60.98% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2414 +/- ##
===========================================
+ Coverage 60.90% 60.98% +0.08%
===========================================
Files 554 550 -4
Lines 14681 14673 -8
===========================================
+ Hits 8942 8949 +7
+ Misses 5739 5724 -15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
monkey/monkey_island/cc/ui/src/components/report-components/security/issues/SmbIssue.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, the file services/reporting/report.py
should not exist. I don't think it's necessary to migrate it to UI now, focusing on one thing at a time is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't found anything worthvile after a quick glance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some simple renaming and LGTM!
What does this PR do?
Fixes part of #2269.
Updates the issues reports. This affects the "Security Findings" > "Immediate Threats" and "Potential Security Issues" lists, as well as the recommendations. Note that these recommendations are more vague/less useful now because we don't have the usernames or service/ports available to indicate which user or which service/port is vulnerable.
Other PRs will focus on:
PR Checklist
Was the CHANGELOG.md updated to reflect the changes?Testing Checklist
Added relevant unit tests?Have you successfully tested your changes locally? Elaborate:
If applicable, add screenshots or log transcripts of the feature working
Here we see the map:
Observe that the "Immediate Threats" are still valid:
Observe that "Potential Security Issues" is valid. Also observe that the "Machine related recommendations" list is populated:
Observe that the expanded items in "Machine related recommendations" are correct: