Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2269 update reports with exploitation events #2414

Merged
merged 22 commits into from
Oct 13, 2022

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Oct 10, 2022

What does this PR do?

Fixes part of #2269.

Updates the issues reports. This affects the "Security Findings" > "Immediate Threats" and "Potential Security Issues" lists, as well as the recommendations. Note that these recommendations are more vague/less useful now because we don't have the usernames or service/ports available to indicate which user or which service/port is vulnerable.

Other PRs will focus on:

  • Removing PTHReportService
  • Updating cross-segmentation reports to use the repositories
  • Updating monkey_exploitation to use the repositories

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?

  • Have you successfully tested your changes locally? Elaborate:

    Tested by running in the zoo envionment

  • If applicable, add screenshots or log transcripts of the feature working
    Here we see the map:
    Screen Shot 2022-10-11 at 9 08 33 AM

    Observe that the "Immediate Threats" are still valid:
    Screen Shot 2022-10-11 at 9 07 48 AM

    Observe that "Potential Security Issues" is valid. Also observe that the "Machine related recommendations" list is populated:
    Screen Shot 2022-10-11 at 9 28 48 AM

    Observe that the expanded items in "Machine related recommendations" are correct:
    Screen Shot 2022-10-11 at 9 30 10 AM
    Screen Shot 2022-10-11 at 9 30 46 AM

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 60.90% // Head: 60.98% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (7086638) compared to base (7fc0aaf).
Patch coverage: 53.84% of modified lines in pull request are covered.

❗ Current head 7086638 differs from pull request most recent head d1cb7e1. Consider uploading reports for the commit d1cb7e1 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2414      +/-   ##
===========================================
+ Coverage    60.90%   60.98%   +0.08%     
===========================================
  Files          554      550       -4     
  Lines        14681    14673       -8     
===========================================
+ Hits          8942     8949       +7     
+ Misses        5739     5724      -15     
Impacted Files Coverage Δ
monkey/monkey_island/cc/services/initialize.py 0.00% <ø> (ø)
monkey/monkey_island/cc/services/node.py 27.74% <ø> (-0.03%) ⬇️
...nkey/monkey_island/cc/services/reporting/report.py 33.20% <40.00%> (+0.81%) ⬆️
...ng/exploit_processing/exploiter_descriptor_enum.py 100.00% <100.00%> (ø)
...essing/exploit_processing/exploiter_report_info.py 100.00% <100.00%> (ø)
monkey/common/agent_event_serializers/register.py 30.00% <0.00%> (-3.34%) ⬇️
monkey/monkey_island/cc/app.py 80.00% <0.00%> (-0.29%) ⬇️
monkey/infection_monkey/monkey.py 0.00% <0.00%> (ø)
monkey/common/agent_events/__init__.py 100.00% <0.00%> (ø)
monkey/monkey_island/cc/models/machine.py 100.00% <0.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cakekoa cakekoa marked this pull request as ready for review October 11, 2022 13:57
Copy link
Contributor

@VakarisZ VakarisZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, the file services/reporting/report.py should not exist. I don't think it's necessary to migrate it to UI now, focusing on one thing at a time is fine.

Copy link
Contributor

@VakarisZ VakarisZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't found anything worthvile after a quick glance

Copy link
Contributor

@ilija-lazoroski ilija-lazoroski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some simple renaming and LGTM!

@cakekoa cakekoa merged commit 2da23c5 into develop Oct 13, 2022
@mssalvatore mssalvatore deleted the 2269-update-reports-with-exploitation-events branch December 1, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants