Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2269 publish events for mssql exploiter #2401

Merged
merged 15 commits into from
Oct 7, 2022

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Oct 5, 2022

What does this PR do?

Fixes part of #2269.

Updates the MSSQL exploiter to publish exploitation and propagation events.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 61.24% // Head: 61.18% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (ec617df) compared to base (e2453e4).
Patch coverage: 4.00% of modified lines in pull request are covered.

❗ Current head ec617df differs from pull request most recent head a558948. Consider uploading reports for the commit a558948 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2401      +/-   ##
===========================================
- Coverage    61.24%   61.18%   -0.07%     
===========================================
  Files          553      553              
  Lines        14443    14459      +16     
===========================================
+ Hits          8846     8847       +1     
- Misses        5597     5612      +15     
Impacted Files Coverage Δ
monkey/common/tags/__init__.py 100.00% <ø> (ø)
monkey/infection_monkey/exploit/mssqlexec.py 0.00% <0.00%> (ø)
...onkey/infection_monkey/exploit/tools/http_tools.py 0.00% <0.00%> (ø)
monkey/common/tags/attack.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@mssalvatore mssalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix timestamps

monkey/infection_monkey/exploit/mssqlexec.py Outdated Show resolved Hide resolved
monkey/infection_monkey/exploit/mssqlexec.py Outdated Show resolved Hide resolved
@cakekoa cakekoa force-pushed the 2269-publish-events-for-mssql-exploiter branch from 6ce423d to 1c74ffc Compare October 5, 2022 20:37
Copy link
Contributor

@shreyamalviya shreyamalviya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant to modify HostExploiter.py as well. The event publishing won't work right now. Ignore

monkey/infection_monkey/exploit/mssqlexec.py Outdated Show resolved Hide resolved
@ilija-lazoroski ilija-lazoroski force-pushed the 2269-publish-events-for-mssql-exploiter branch from 1add95f to 15974ff Compare October 6, 2022 11:37
@mssalvatore mssalvatore merged commit 6d60e33 into develop Oct 7, 2022
@mssalvatore mssalvatore deleted the 2269-publish-events-for-mssql-exploiter branch October 7, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants