Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2269 add attack technique tags #2394

Merged
merged 14 commits into from
Oct 5, 2022
Merged

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Oct 4, 2022

What does this PR do?

Fixes part of #2269.

Create attack technique tags to be used by the exploiters when publishing events. @ilija-lazoroski

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

Copy link
Collaborator

@mssalvatore mssalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All components that publish events should use these. The ones I know about are:
Mimikatz credential collector
SSH credential collector
Zerologon exploiter

Base automatically changed from 2269-update-hostexploiter to develop October 4, 2022 19:34
Copy link
Collaborator

@mssalvatore mssalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but fix vulture warnings.

@mssalvatore mssalvatore merged commit 73a8c14 into develop Oct 5, 2022
@ilija-lazoroski ilija-lazoroski deleted the 2269-add-attack-technique-tags branch October 5, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants