Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2269 remove find monkeys in db #2391

Merged
merged 6 commits into from
Oct 4, 2022
Merged

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Oct 3, 2022

What does this PR do?

Fixes part of #2269.

Refactors is_all_monkeys_dead, which freed up find_monkeys_in_db to be removed. Took the opportunity to refactor test_os_compat and remove get_all_monkeys_from_db as well.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 61.17% // Head: 61.15% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (bbbb1ac) compared to base (a691a16).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2391      +/-   ##
===========================================
- Coverage    61.17%   61.15%   -0.02%     
===========================================
  Files          553      551       -2     
  Lines        14432    14404      -28     
===========================================
- Hits          8829     8809      -20     
+ Misses        5603     5595       -8     
Impacted Files Coverage Δ
monkey/monkey_island/cc/app.py 80.28% <ø> (-0.55%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mssalvatore mssalvatore force-pushed the 2269-remove-find_monkeys_in_db branch from e4fdf90 to 01c947b Compare October 4, 2022 20:03
@mssalvatore mssalvatore marked this pull request as ready for review October 4, 2022 20:26
@mssalvatore mssalvatore force-pushed the 2269-remove-find_monkeys_in_db branch from dc300de to bbbb1ac Compare October 4, 2022 20:30
@mssalvatore mssalvatore merged commit fd8ea53 into develop Oct 4, 2022
@mssalvatore mssalvatore deleted the 2269-remove-find_monkeys_in_db branch October 4, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants