-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define Propagation Event #2385
Define Propagation Event #2385
Conversation
Codecov ReportBase: 61.20% // Head: 61.22% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2385 +/- ##
===========================================
+ Coverage 61.20% 61.22% +0.02%
===========================================
Files 550 551 +1
Lines 14410 14419 +9
===========================================
+ Hits 8819 8828 +9
Misses 5591 5591
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
e027941
to
5b9811f
Compare
:param error_message: Message if an error occurs during propagation | ||
""" | ||
|
||
target: IPv4Address |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to document this field as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we are overriding the field, I don't think it is really needed.
5b9811f
to
d1af356
Compare
What does this PR do?
Fixes part of #2269 .
Add any further explanations here.
PR Checklist
Was the CHANGELOG.md updated to reflect the changes?Was the documentation framework updated to reflect the changes?Testing Checklist