Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Propagation Event #2385

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Define Propagation Event #2385

merged 2 commits into from
Oct 3, 2022

Conversation

ilija-lazoroski
Copy link
Contributor

What does this PR do?

Fixes part of #2269 .

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 61.20% // Head: 61.22% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (5b9811f) compared to base (25f1230).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 5b9811f differs from pull request most recent head d1af356. Consider uploading reports for the commit d1af356 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2385      +/-   ##
===========================================
+ Coverage    61.20%   61.22%   +0.02%     
===========================================
  Files          550      551       +1     
  Lines        14410    14419       +9     
===========================================
+ Hits          8819     8828       +9     
  Misses        5591     5591              
Impacted Files Coverage Δ
monkey/common/agent_events/__init__.py 100.00% <100.00%> (ø)
monkey/common/agent_events/propagation_event.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ilija-lazoroski ilija-lazoroski force-pushed the 2269-propagation-event branch 2 times, most recently from e027941 to 5b9811f Compare October 3, 2022 13:00
:param error_message: Message if an error occurs during propagation
"""

target: IPv4Address
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to document this field as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are overriding the field, I don't think it is really needed.

@mssalvatore mssalvatore merged commit 07839a4 into develop Oct 3, 2022
@mssalvatore mssalvatore deleted the 2269-propagation-event branch October 3, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants