2004 scan target configuration

[VakarisZ]

What does this PR do?

Fixes network target configuration part of #2004

Add any further explanations here.

PR Checklist

• Have you added an explanation of what your changes do and why you'd like to include them?
• Is the TravisCI build passing?
• Was the CHANGELOG.md updated to reflect the changes?
• Was the documentation framework updated to reflect the changes?
• Have you checked that you haven't introduced any duplicate code?

Testing Checklist

• Added relevant unit tests?
• Have you successfully tested your changes locally? Elaborate:

  Tested by running the added unit tests

• If applicable, add screenshots or log transcripts of the feature working

[codecov]

Codecov Report

Merging #2133 (22b3874) into develop (85211c3) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2133      +/-   ##
===========================================
+ Coverage    56.64%   56.89%   +0.24%     
===========================================
  Files          486      489       +3     
  Lines        13226    13278      +52     
===========================================
+ Hits          7492     7554      +62     
+ Misses        5734     5724      -10     

Impacted Files	Coverage Δ
...on/agent_configuration/agent_sub_configurations.py	100.00% <ø> (ø)
...t_configuration/agent_sub_configuration_schemas.py	100.00% <100.00%> (ø)
.../common/agent_configuration/validators/__init__.py	100.00% <100.00%> (ø)
...common/agent_configuration/validators/filenames.py	100.00% <100.00%> (ø)
...common/agent_configuration/validators/ip_ranges.py	100.00% <100.00%> (ø)
.../monkey_island/in_memory_credentials_repository.py	87.50% <0.00%> (-4.17%)	⬇️
...onkey/monkey_island/cc/services/representations.py	89.28% <0.00%> (-3.03%)	⬇️
monkey/infection_monkey/exploit/zerologon.py	30.82% <0.00%> (ø)
monkey/infection_monkey/master/propagator.py	98.98% <0.00%> (+0.13%)	⬆️
...key_island/cc/resources/propagation_credentials.py	100.00% <0.00%> (+23.52%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85211c3...22b3874. Read the comment docs.

[shreyamalviya]

If we're not going to be using the IP range validators anywhere else, move them to be inside the schema class, as done with CustomPBAConfigurationSchema. Or move that validation out to a separate file. The former makes more sense to me but in any case, this needs to be consistent.

[VakarisZ]

If we're not going to be using the IP range validators anywhere else, move them to be inside the schema class, as done with CustomPBAConfigurationSchema. Or move that validation out to a separate file. The former makes more sense to me but in any case, this needs to be consistent.

We can use them on any hostname, ip or ip range input. Moving them into schema would require some work and I'm not sure we even gain anything. I would rather move the windows filename validation away into validators. It makes the schema smaller, separates validation responsibility and once we need to upload more files we won't need to rework the schema

[mssalvatore]

Suggested change

	if match and match.group() == hostname:
	return
	else:
	raise ValidationError(f"Invalid hostname {hostname}")
	if not (match and match.group() == hostname):
	raise ValidationError(f"Invalid hostname {hostname}")

[mssalvatore]

If you do the length check first you don't need to handle IndexError.

Suggested change

	try:
	ip_range = ip_range.replace(" ", "")
	ips = ip_range.split("-")
	validate_ip(ips[0])
	validate_ip(ips[1])
	if len(ips) != 2:
	raise ValidationError(f"Invalid IP range {ip_range}")
	except (AddressValueError, IndexError):
	raise ValidationError(f"Invalid IP range {ip_range}")
	ip_range = ip_range.replace(" ", "")
	ips = ip_range.split("-")
	if len(ips) != 2:
	raise ValidationError(f"Invalid IP range {ip_range}")
	try:
	validate_ip(ips[0])
	validate_ip(ips[1])
	except AddressValueError:
	raise ValidationError(f"Invalid IP range {ip_range}")

[shreyamalviya]

UTs missing for ScanTargetConfiguration in tests/unit_tests/common/configuration/test_agent_configuration.py and for common/agent_configuration/validators/filenames.py

[shreyamalviya]

Suggested change

	def validate_windows_filename(windows_filename: str):
	validate_windows_filename_not_reserved(windows_filename)
	if not re.match(_valid_windows_filename_regex, windows_filename):
	raise ValidationError(f"Invalid Windows filename {windows_filename}: illegal characters")
	def validate_windows_filename_not_reserved(windows_filename: str):
	def validate_windows_filename(windows_filename: str):
	_validate_windows_filename_not_reserved(windows_filename)
	if not re.match(_valid_windows_filename_regex, windows_filename):
	raise ValidationError(f"Invalid Windows filename {windows_filename}: illegal characters")
	def _validate_windows_filename_not_reserved(windows_filename: str):

[mssalvatore]

Fantastic!