Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropagationConfiguration docstring + validation #2129

Merged
merged 8 commits into from
Jul 27, 2022

Conversation

shreyamalviya
Copy link
Contributor

@shreyamalviya shreyamalviya commented Jul 27, 2022

What does this PR do?

Fixes a part of #2004

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    UTs pass

  • If applicable, add screenshots or log transcripts of the feature working
    image

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #2129 (6da238f) into develop (643896b) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 6da238f differs from pull request most recent head c2052a5. Consider uploading reports for the commit c2052a5 to get more accurate results

@@           Coverage Diff            @@
##           develop    #2129   +/-   ##
========================================
  Coverage    56.64%   56.64%           
========================================
  Files          486      486           
  Lines        13227    13227           
========================================
  Hits          7493     7493           
  Misses        5734     5734           
Impacted Files Coverage Δ
...t_configuration/agent_sub_configuration_schemas.py 100.00% <100.00%> (ø)
...on/agent_configuration/agent_sub_configurations.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 643896b...c2052a5. Read the comment docs.

@shreyamalviya shreyamalviya force-pushed the 2004-propagation-configuration-validation branch from 85ccfaa to c2052a5 Compare July 27, 2022 13:38
@mssalvatore mssalvatore merged commit 40b29ba into develop Jul 27, 2022
@mssalvatore mssalvatore deleted the 2004-propagation-configuration-validation branch July 27, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants