Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common: Rename configuration package to agent_configuration #2116

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

VakarisZ
Copy link
Contributor

What does this PR do?

Renames configuration to agent_configuration as part of #2004

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running UT's

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #2116 (c4aea69) into develop (4d3fb03) will not change coverage.
The diff coverage is 85.71%.

@@           Coverage Diff            @@
##           develop    #2116   +/-   ##
========================================
  Coverage    56.55%   56.55%           
========================================
  Files          485      485           
  Lines        13198    13198           
========================================
  Hits          7464     7464           
  Misses        5734     5734           
Impacted Files Coverage Δ
monkey/common/agent_configuration/__init__.py 100.00% <ø> (ø)
.../common/agent_configuration/agent_configuration.py 100.00% <ø> (ø)
...t_configuration/agent_sub_configuration_schemas.py 100.00% <ø> (ø)
...on/agent_configuration/agent_sub_configurations.py 100.00% <ø> (ø)
...agent_configuration/default_agent_configuration.py 100.00% <ø> (ø)
monkey/monkey_island/cc/services/initialize.py 0.00% <0.00%> (ø)
monkey/infection_monkey/i_control_channel.py 85.71% <100.00%> (ø)
monkey/infection_monkey/master/automated_master.py 84.44% <100.00%> (ø)
monkey/infection_monkey/master/control_channel.py 36.36% <100.00%> (ø)
monkey/infection_monkey/master/exploiter.py 96.10% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d3fb03...c4aea69. Read the comment docs.

Copy link
Contributor

@shreyamalviya shreyamalviya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed the imports in the blackbox tests.

@mssalvatore mssalvatore merged commit 81101d4 into develop Jul 26, 2022
@mssalvatore mssalvatore deleted the 2004-agent-config-renaming branch July 26, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants