Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent configuration construction #2041

Merged
merged 18 commits into from
Jun 24, 2022
Merged

Agent configuration construction #2041

merged 18 commits into from
Jun 24, 2022

Conversation

mssalvatore
Copy link
Collaborator

What does this PR do?

  • Remove circular dependency between AgentConfiguration and AgentConfigurationSchema
  • Add methods to convert to/from JSON
  • Encapsulate Marshmallow
  • Prevent invalid objects from being constructed

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running unit tests
    Tested by running ETE tests

  • If applicable, add screenshots or log transcripts of the feature working

@mssalvatore
UT: Move test_agent_configuration.py to configuration/
e3cea20
@mssalvatore
Common: Rename _dict -> dict_
5c73971
@mssalvatore
UT: Add a test for AgentConfiguration.from_dict()
8605fd4
@mssalvatore
Agent: Add AgentConfiguration.from_json()
1f9a056
@mssalvatore
Common: Add AgentConfiguration.to_json()
28250da
@mssalvatore
UT: Use from_dict() and from_json() in tests
e4eee6a
@mssalvatore
Island: Use {from,to}_json() in FileAgentConfigurationRepository
6a92726
@mssalvatore
Common: Use from_json() in build_default_agent_configuration()
a1baaae
@mssalvatore
Island: Use {from,to}_json() in resources
07d1d9c
@mssalvatore
Common: Encapsulate AgentConfigurationSchema
4c47eae
@mssalvatore
Common: Remove circular dependency in agent_configuration.py
ea02bec
@mssalvatore
Common: Add validation to AgentConfiguration construction
fc9d854
@mssalvatore
Common: Add InvalidConfigurationError
94524d1
@mssalvatore
Common: Encapsulate MarshmallowError
dbd0d3e
@mssalvatore
Common: Rename dict_ -> config_dict
e2f365a
@mssalvatore
Common: Rename from_dict() -> from_mapping()
334d2a7
@mssalvatore
Common: Fix incorrect type hints on AgentConfiguration.from_json()
8cb045d
@mssalvatore
Common: Add docstrings to static methods in AgentConfiguration
568eb4f
@mssalvatore mssalvatore changed the base branch from develop to 1960-deserialize-config June 24, 2022 17:36
@mssalvatore mssalvatore merged commit 93ed7cf into 1960-deserialize-config Jun 24, 2022
@mssalvatore mssalvatore deleted the agent-configuration-construction branch June 24, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija-lazoroski ilija-lazoroski ilija-lazoroski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mssalvatore @ilija-lazoroski