Add IAgentRepository to simplify agent download during propagation #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyamalviya
approved these changes
Mar 2, 2022
Comment on lines
45
to
46
| file_sha256_hash = filename, hashlib.sha256(file_contents).hexdigest() | ||
| logger.debug(f"{filename} hash:\nSHA-256 {file_sha256_hash}") |
There was a problem hiding this comment.
Filename is logged twice?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces
IAgentRepository, a simpler way for exploiters to retrieve the agent binaries they need for propagation. The API endpoint on the island has been simplified, which helps to simplify the process of downloading agents from the island. Themonkeyfsis superseded byIAgentRepositoryand has therefore been removed. Both the SSH and Hadoop exploiters have been modified to use the new interface.Issue #1675
Add any further explanations here.
PR Checklist
Is the TravisCI build passing?Was the CHANGELOG.md updated to reflect the changes?Was the documentation framework updated to reflect the changes?Testing Checklist
Added relevant unit tests?If applicable, add screenshots or log transcripts of the feature working