Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1537 try to move dropper file first #1588

Merged
merged 4 commits into from
Nov 15, 2021
Merged

Conversation

ilija-lazoroski
Copy link
Contributor

What does this PR do?

Fixes #1537 always try to move dropper first.

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

Explain Changes

image

@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #1588 (de0fff9) into develop (5c66850) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1588      +/-   ##
===========================================
- Coverage    44.75%   44.75%   -0.01%     
===========================================
  Files          474      474              
  Lines        13859    13858       -1     
===========================================
- Hits          6203     6202       -1     
  Misses        7656     7656              
Impacted Files Coverage Δ
monkey/infection_monkey/config.py 62.01% <ø> (-0.30%) ⬇️
monkey/infection_monkey/dropper.py 0.00% <0.00%> (ø)
...onkey_island/cc/services/config_schema/internal.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c66850...de0fff9. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
and os.path.exists(self._config["source_path"])
and WormConfiguration.dropper_try_move_first
):
self._config["source_path"].lower() != self._config["destination_path"].lower()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have brackets around this?

@ilija-lazoroski ilija-lazoroski force-pushed the 1537-try-to-move-first branch 2 times, most recently from 8afb65b to de0fff9 Compare November 15, 2021 13:25
@ilija-lazoroski ilija-lazoroski merged commit e0abe19 into develop Nov 15, 2021
@ilija-lazoroski ilija-lazoroski deleted the 1537-try-to-move-first branch November 15, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused/untested options
3 participants