Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1537 remove serialize config #1587

Merged
merged 4 commits into from
Nov 15, 2021
Merged

Conversation

ilija-lazoroski
Copy link
Contributor

@ilija-lazoroski ilija-lazoroski commented Nov 12, 2021

What does this PR do?

Fixes #1537 remove serialize config.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

Explain Changes

image

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #1587 (cb06f40) into develop (c6db7a6) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1587   +/-   ##
========================================
  Coverage    44.74%   44.75%           
========================================
  Files          474      474           
  Lines        13864    13859    -5     
========================================
- Hits          6204     6203    -1     
+ Misses        7660     7656    -4     
Impacted Files Coverage Δ
monkey/infection_monkey/config.py 62.30% <ø> (-0.29%) ⬇️
monkey/infection_monkey/main.py 0.00% <ø> (ø)
...onkey_island/cc/services/config_schema/internal.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6db7a6...cb06f40. Read the comment docs.

@ilija-lazoroski ilija-lazoroski force-pushed the 1537-remove-serialize-config branch 3 times, most recently from 58fb543 to cb06f40 Compare November 15, 2021 12:42
@ilija-lazoroski ilija-lazoroski merged commit 5c66850 into develop Nov 15, 2021
@ilija-lazoroski ilija-lazoroski deleted the 1537-remove-serialize-config branch November 15, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused/untested options
2 participants