Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mimikatz collector fix #1512

Merged
merged 2 commits into from
Oct 5, 2021
Merged

Mimikatz collector fix #1512

merged 2 commits into from
Oct 5, 2021

Conversation

VakarisZ
Copy link
Contributor

@VakarisZ VakarisZ commented Oct 5, 2021

What does this PR do?

Fixes a bug where mimikatz data doesn't get collected whenever the azure collector is disabled

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running monkey with azure disabled/enabled and assessing results in telemetries.

This change cleans up the code because the info collectors can just add credentials to the info dictionary without explicitly checking if the key already exists
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #1512 (bbda934) into develop (19765c7) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head bbda934 differs from pull request most recent head bc42212. Consider uploading reports for the commit bc42212 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1512   +/-   ##
========================================
  Coverage    42.99%   43.00%           
========================================
  Files          477      477           
  Lines        14174    14171    -3     
========================================
  Hits          6094     6094           
+ Misses        8080     8077    -3     
Impacted Files Coverage Δ
monkey/infection_monkey/system_info/__init__.py 42.62% <0.00%> (+1.35%) ⬆️
...ction_monkey/system_info/windows_info_collector.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19765c7...bc42212. Read the comment docs.

Copy link
Collaborator

@mssalvatore mssalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but needs changelog

…tor when Azure credential collector is disabled
@VakarisZ VakarisZ merged commit 0a4973a into develop Oct 5, 2021
@VakarisZ VakarisZ deleted the mimikatz_collector_fix branch October 5, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants